From d4f519c580cc981ecb997092e323993fe7be1ba9 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sat, 21 Feb 2026 02:58:27 +0000 Subject: [PATCH] fix: address code review comments Co-authored-by: abhi1693 <5083532+abhi1693@users.noreply.github.com> --- backend/app/api/agent.py | 12 +++++------- frontend/src/app/agents/[agentId]/files/page.tsx | 7 ++++++- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/backend/app/api/agent.py b/backend/app/api/agent.py index a4610f57..e5ddb84f 100644 --- a/backend/app/api/agent.py +++ b/backend/app/api/agent.py @@ -24,6 +24,7 @@ from app.models.boards import Board from app.models.tags import Tag from app.models.task_dependencies import TaskDependency from app.models.tasks import Task +from app.schemas.agent_files import AgentFileUpdate from app.schemas.agents import ( AgentCreate, AgentHeartbeat, @@ -1695,7 +1696,7 @@ async def read_agent_file( async def update_agent_file( agent_id: str, filename: str, - payload: dict[str, str], + payload: AgentFileUpdate, board: Board = BOARD_DEP, session: AsyncSession = SESSION_DEP, agent_ctx: AgentAuthContext = AGENT_CTX_DEP, @@ -1706,17 +1707,14 @@ async def update_agent_file( """ _guard_board_access(agent_ctx, board) _require_board_lead(agent_ctx) - - content = payload.get("content", "") - reason = payload.get("reason") - + coordination = GatewayCoordinationService(session) await coordination.update_agent_file( board=board, target_agent_id=agent_id, filename=filename, - content=content, - reason=reason, + content=payload.content, + reason=payload.reason, actor_agent_id=agent_ctx.agent.id, correlation_id=f"file.write:{board.id}:{agent_id}:{filename}", ) diff --git a/frontend/src/app/agents/[agentId]/files/page.tsx b/frontend/src/app/agents/[agentId]/files/page.tsx index 9edb4e90..c6067c83 100644 --- a/frontend/src/app/agents/[agentId]/files/page.tsx +++ b/frontend/src/app/agents/[agentId]/files/page.tsx @@ -27,6 +27,11 @@ import { import { useOrganizationMembership } from "@/lib/use-organization-membership"; import type { AgentRead } from "@/api/generated/model"; +type AgentFile = { + name: string; + editable: boolean; +}; + export default function AgentFilesPage() { const { isSignedIn } = useAuth(); const router = useRouter(); @@ -36,7 +41,7 @@ export default function AgentFilesPage() { const { isAdmin } = useOrganizationMembership(isSignedIn); - const [files, setFiles] = useState>([]); + const [files, setFiles] = useState([]); const [selectedFile, setSelectedFile] = useState(null); const [fileContent, setFileContent] = useState(""); const [editDialogOpen, setEditDialogOpen] = useState(false);