From c3490630a4503d9c8142aaa3abf542e0d00b5035 Mon Sep 17 00:00:00 2001 From: Abhimanyu Saharan Date: Wed, 11 Feb 2026 10:47:32 +0530 Subject: [PATCH] refactor: clean up imports and improve session key assertion formatting --- backend/app/api/board_onboarding.py | 2 +- backend/app/api/boards.py | 10 ---------- backend/app/services/board_lifecycle.py | 1 - .../app/services/openclaw/gateway_dispatch.py | 2 +- backend/tests/test_session_keys.py | 18 +++++++++--------- 5 files changed, 11 insertions(+), 22 deletions(-) diff --git a/backend/app/api/board_onboarding.py b/backend/app/api/board_onboarding.py index e7ec8ded..d4309ffd 100644 --- a/backend/app/api/board_onboarding.py +++ b/backend/app/api/board_onboarding.py @@ -32,8 +32,8 @@ from app.schemas.board_onboarding import ( BoardOnboardingUserProfile, ) from app.schemas.boards import BoardRead -from app.services.openclaw.gateway_resolver import get_gateway_for_board from app.services.openclaw.gateway_dispatch import GatewayDispatchService +from app.services.openclaw.gateway_resolver import get_gateway_for_board from app.services.openclaw.onboarding_service import BoardOnboardingMessagingService from app.services.openclaw.policies import OpenClawAuthorizationPolicy from app.services.openclaw.provisioning_db import ( diff --git a/backend/app/api/boards.py b/backend/app/api/boards.py index 286239fe..7fed49ac 100644 --- a/backend/app/api/boards.py +++ b/backend/app/api/boards.py @@ -20,19 +20,9 @@ from app.core.time import utcnow from app.db import crud from app.db.pagination import paginate from app.db.session import get_session -from app.models.activity_events import ActivityEvent -from app.models.agents import Agent -from app.models.approvals import Approval from app.models.board_groups import BoardGroup -from app.models.board_memory import BoardMemory -from app.models.board_onboarding import BoardOnboardingSession from app.models.boards import Board from app.models.gateways import Gateway -from app.models.organization_board_access import OrganizationBoardAccess -from app.models.organization_invite_board_access import OrganizationInviteBoardAccess -from app.models.task_dependencies import TaskDependency -from app.models.task_fingerprints import TaskFingerprint -from app.models.tasks import Task from app.schemas.boards import BoardCreate, BoardRead, BoardUpdate from app.schemas.common import OkResponse from app.schemas.pagination import DefaultLimitOffsetPage diff --git a/backend/app/services/board_lifecycle.py b/backend/app/services/board_lifecycle.py index 8ece4a42..26fb2f6c 100644 --- a/backend/app/services/board_lifecycle.py +++ b/backend/app/services/board_lifecycle.py @@ -109,4 +109,3 @@ async def delete_board(session: AsyncSession, *, board: Board) -> OkResponse: await session.delete(board) await session.commit() return OkResponse() - diff --git a/backend/app/services/openclaw/gateway_dispatch.py b/backend/app/services/openclaw/gateway_dispatch.py index 17d24bd2..2b20ee6e 100644 --- a/backend/app/services/openclaw/gateway_dispatch.py +++ b/backend/app/services/openclaw/gateway_dispatch.py @@ -12,8 +12,8 @@ from app.models.boards import Board from app.models.gateways import Gateway from app.services.openclaw.db_service import OpenClawDBService from app.services.openclaw.gateway_resolver import ( - get_gateway_for_board, gateway_client_config, + get_gateway_for_board, optional_gateway_client_config, require_gateway_for_board, ) diff --git a/backend/tests/test_session_keys.py b/backend/tests/test_session_keys.py index f66216cf..83333c16 100644 --- a/backend/tests/test_session_keys.py +++ b/backend/tests/test_session_keys.py @@ -16,7 +16,9 @@ from app.services.openclaw.shared import GatewayAgentIdentity def test_gateway_main_session_key_matches_gateway_identity() -> None: gateway_id = UUID("00000000-0000-0000-0000-000000000123") - assert gateway_main_session_key(gateway_id) == GatewayAgentIdentity.session_key_for_id(gateway_id) + assert gateway_main_session_key(gateway_id) == GatewayAgentIdentity.session_key_for_id( + gateway_id + ) def test_board_lead_session_key_format() -> None: @@ -32,16 +34,14 @@ def test_board_agent_session_key_format() -> None: def test_board_scoped_session_key_selects_lead() -> None: agent_id = UUID("00000000-0000-0000-0000-000000000001") board_id = UUID("00000000-0000-0000-0000-000000000002") - assert ( - board_scoped_session_key(agent_id=agent_id, board_id=board_id, is_board_lead=True) - == board_lead_session_key(board_id) - ) + assert board_scoped_session_key( + agent_id=agent_id, board_id=board_id, is_board_lead=True + ) == board_lead_session_key(board_id) def test_board_scoped_session_key_selects_non_lead() -> None: agent_id = UUID("00000000-0000-0000-0000-000000000001") board_id = UUID("00000000-0000-0000-0000-000000000002") - assert ( - board_scoped_session_key(agent_id=agent_id, board_id=board_id, is_board_lead=False) - == board_agent_session_key(agent_id) - ) + assert board_scoped_session_key( + agent_id=agent_id, board_id=board_id, is_board_lead=False + ) == board_agent_session_key(agent_id)