redesigned dashboard page
This commit is contained in:
@@ -5,7 +5,7 @@ from uuid import uuid4
|
||||
|
||||
import pytest
|
||||
|
||||
from app.api.activity import _coerce_task_comment_rows
|
||||
from app.api.activity import _build_activity_route, _coerce_activity_rows, _coerce_task_comment_rows
|
||||
from app.models.activity_events import ActivityEvent
|
||||
from app.models.agents import Agent
|
||||
from app.models.boards import Board
|
||||
@@ -34,6 +34,25 @@ class _FakeSqlRow4:
|
||||
raise IndexError(index)
|
||||
|
||||
|
||||
@dataclass
|
||||
class _FakeSqlRow3:
|
||||
first: object
|
||||
second: object
|
||||
third: object
|
||||
|
||||
def __len__(self) -> int:
|
||||
return 3
|
||||
|
||||
def __getitem__(self, index: int) -> object:
|
||||
if index == 0:
|
||||
return self.first
|
||||
if index == 1:
|
||||
return self.second
|
||||
if index == 2:
|
||||
return self.third
|
||||
raise IndexError(index)
|
||||
|
||||
|
||||
def _make_event() -> ActivityEvent:
|
||||
return ActivityEvent(event_type="task.comment", message="hello")
|
||||
|
||||
@@ -87,3 +106,71 @@ def test_coerce_task_comment_rows_rejects_invalid_values():
|
||||
match="Expected \\(ActivityEvent, Task, Board, Agent \\| None\\) rows",
|
||||
):
|
||||
_coerce_task_comment_rows([(uuid4(), task, board, None)])
|
||||
|
||||
|
||||
def test_coerce_activity_rows_accepts_plain_tuple():
|
||||
board_id = uuid4()
|
||||
event = _make_event()
|
||||
|
||||
rows = _coerce_activity_rows([(event, board_id, None)])
|
||||
assert rows == [(event, board_id, None)]
|
||||
|
||||
|
||||
def test_coerce_activity_rows_accepts_row_like_values():
|
||||
board_id = uuid4()
|
||||
event = _make_event()
|
||||
row = _FakeSqlRow3(event, board_id, None)
|
||||
|
||||
rows = _coerce_activity_rows([row])
|
||||
assert rows == [(event, board_id, None)]
|
||||
|
||||
|
||||
def test_coerce_activity_rows_rejects_invalid_values():
|
||||
event = _make_event()
|
||||
with pytest.raises(
|
||||
TypeError,
|
||||
match=(
|
||||
"Expected \\(ActivityEvent, event_board_id, task_board_id\\) rows"
|
||||
),
|
||||
):
|
||||
_coerce_activity_rows([(event, "bad", None)])
|
||||
|
||||
|
||||
def test_build_activity_route_board_comment():
|
||||
board_id = uuid4()
|
||||
task_id = uuid4()
|
||||
event = ActivityEvent(
|
||||
event_type="task.comment",
|
||||
task_id=task_id,
|
||||
message="hello",
|
||||
)
|
||||
route_name, route_params = _build_activity_route(event=event, board_id=board_id)
|
||||
assert route_name == "board"
|
||||
assert route_params == {
|
||||
"boardId": str(board_id),
|
||||
"taskId": str(task_id),
|
||||
"commentId": str(event.id),
|
||||
}
|
||||
|
||||
|
||||
def test_build_activity_route_board_approvals():
|
||||
board_id = uuid4()
|
||||
event = ActivityEvent(
|
||||
event_type="approval.lead_notified",
|
||||
message="hello",
|
||||
)
|
||||
route_name, route_params = _build_activity_route(event=event, board_id=board_id)
|
||||
assert route_name == "board.approvals"
|
||||
assert route_params == {"boardId": str(board_id)}
|
||||
|
||||
|
||||
def test_build_activity_route_global_fallback():
|
||||
event = ActivityEvent(
|
||||
event_type="gateway.main.lead_broadcast.sent",
|
||||
message="hello",
|
||||
)
|
||||
route_name, route_params = _build_activity_route(event=event, board_id=None)
|
||||
assert route_name == "activity"
|
||||
assert route_params["eventId"] == str(event.id)
|
||||
assert route_params["eventType"] == event.event_type
|
||||
assert route_params["createdAt"] == event.created_at.isoformat()
|
||||
|
||||
@@ -62,6 +62,7 @@ async def test_delete_board_cleans_org_board_access_rows() -> None:
|
||||
)
|
||||
|
||||
deleted_table_names = [statement.table.name for statement in session.executed]
|
||||
assert "activity_events" in deleted_table_names
|
||||
assert "organization_board_access" in deleted_table_names
|
||||
assert "organization_invite_board_access" in deleted_table_names
|
||||
assert "board_task_custom_fields" in deleted_table_names
|
||||
|
||||
130
backend/tests/test_metrics_kpis.py
Normal file
130
backend/tests/test_metrics_kpis.py
Normal file
@@ -0,0 +1,130 @@
|
||||
from __future__ import annotations
|
||||
|
||||
from datetime import datetime
|
||||
from uuid import uuid4
|
||||
|
||||
import pytest
|
||||
|
||||
from app.api import metrics as metrics_api
|
||||
|
||||
|
||||
class _ExecResult:
|
||||
def __init__(self, rows: list[tuple[str, int]]) -> None:
|
||||
self._rows = rows
|
||||
|
||||
def all(self) -> list[tuple[str, int]]:
|
||||
return self._rows
|
||||
|
||||
|
||||
class _FakeSession:
|
||||
def __init__(self, rows: list[tuple[str, int]]) -> None:
|
||||
self._rows = rows
|
||||
|
||||
async def exec(self, _statement: object) -> _ExecResult:
|
||||
return _ExecResult(self._rows)
|
||||
|
||||
|
||||
class _ExecOneResult:
|
||||
def __init__(self, value: int) -> None:
|
||||
self._value = value
|
||||
|
||||
def one(self) -> int:
|
||||
return self._value
|
||||
|
||||
|
||||
class _ExecAllResult:
|
||||
def __init__(self, rows: list[tuple[object, ...]]) -> None:
|
||||
self._rows = rows
|
||||
|
||||
def all(self) -> list[tuple[object, ...]]:
|
||||
return self._rows
|
||||
|
||||
|
||||
class _SequentialSession:
|
||||
def __init__(self, responses: list[object]) -> None:
|
||||
self._responses = responses
|
||||
self._index = 0
|
||||
|
||||
async def exec(self, _statement: object) -> object:
|
||||
response = self._responses[self._index]
|
||||
self._index += 1
|
||||
return response
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_task_status_counts_returns_zeroes_for_empty_board_scope() -> None:
|
||||
counts = await metrics_api._task_status_counts(_FakeSession([]), [])
|
||||
|
||||
assert counts == {
|
||||
"inbox": 0,
|
||||
"in_progress": 0,
|
||||
"review": 0,
|
||||
"done": 0,
|
||||
}
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_task_status_counts_maps_known_statuses() -> None:
|
||||
session = _FakeSession(
|
||||
[
|
||||
("inbox", 4),
|
||||
("in_progress", 3),
|
||||
("review", 2),
|
||||
("done", 7),
|
||||
("blocked", 99),
|
||||
],
|
||||
)
|
||||
|
||||
counts = await metrics_api._task_status_counts(session, [uuid4()])
|
||||
|
||||
assert counts == {
|
||||
"inbox": 4,
|
||||
"in_progress": 3,
|
||||
"review": 2,
|
||||
"done": 7,
|
||||
}
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_pending_approvals_snapshot_returns_empty_for_empty_scope() -> None:
|
||||
snapshot = await metrics_api._pending_approvals_snapshot(_SequentialSession([]), [])
|
||||
|
||||
assert snapshot.total == 0
|
||||
assert snapshot.items == []
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_pending_approvals_snapshot_maps_rows() -> None:
|
||||
approval_id = uuid4()
|
||||
board_id = uuid4()
|
||||
created_at = datetime(2026, 3, 4, 12, 0, 0)
|
||||
rows: list[tuple[object, ...]] = [
|
||||
(
|
||||
approval_id,
|
||||
board_id,
|
||||
"Operations Board",
|
||||
"approve_task",
|
||||
87.0,
|
||||
created_at,
|
||||
"Validate rollout checklist",
|
||||
)
|
||||
]
|
||||
session = _SequentialSession(
|
||||
[
|
||||
_ExecOneResult(3),
|
||||
_ExecAllResult(rows),
|
||||
]
|
||||
)
|
||||
|
||||
snapshot = await metrics_api._pending_approvals_snapshot(session, [board_id], limit=10)
|
||||
|
||||
assert snapshot.total == 3
|
||||
assert len(snapshot.items) == 1
|
||||
item = snapshot.items[0]
|
||||
assert item.approval_id == approval_id
|
||||
assert item.board_id == board_id
|
||||
assert item.board_name == "Operations Board"
|
||||
assert item.action_type == "approve_task"
|
||||
assert item.confidence == 87.0
|
||||
assert item.created_at == created_at
|
||||
assert item.task_title == "Validate rollout checklist"
|
||||
Reference in New Issue
Block a user