yunxiafei/openclaw-mission-control
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(backend): reject lead updates on blocked tasks (409)

Browse Source 
- Remove silent blocked-task reset in _apply_lead_task_update\n- Include stable error code in blocked task payload\n- Add regression tests asserting 409 + DB unchanged
This commit is contained in:
Abhimanyu Saharan
2026-02-13 20:10:35 +00:00
parent 52f0ca79e0
commit 8c10cef90f
2 changed files with 214 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
backend/app/api/tasks.py
View File

@@ -127,10 +127,12 @@ def _comment_validation_error() -> HTTPException:
def _blocked_task_error(blocked_by_task_ids: Sequence[UUID]) -> HTTPException:
# NOTE: Keep this payload machine-readable; UI and automation rely on it.
return HTTPException(
status_code=status.HTTP_409_CONFLICT,
detail={
"message": "Task is blocked by incomplete dependencies.",
"code": "task_blocked_cannot_transition",
"blocked_by_task_ids": [str(value) for value in blocked_by_task_ids],
},
)
@@ -1960,11 +1962,17 @@ async def _apply_lead_task_update(
update=update,
)
if blocked_by and update.task.status != "done":
update.task.status = "inbox"
update.task.assigned_agent_id = None
update.task.in_progress_at = None
else:
# Blocked tasks should not be silently rewritten into a "blocked-safe" state.
# Instead, reject assignment/status transitions with an explicit 409 payload.
if blocked_by:
attempted_fields: set[str] = set(update.updates.keys())
attempted_transition = (
"assigned_agent_id" in attempted_fields
or "status" in attempted_fields
)
if attempted_transition:
raise _blocked_task_error(blocked_by)
await _lead_apply_assignment(session, update=update)
_lead_apply_status(update)
await _require_no_pending_approval_for_status_change_when_enabled(

199
backend/tests/test_tasks_blocked_lead_transitions.py Normal file
View File

@@ -0,0 +1,199 @@
# ruff: noqa: INP001
from __future__ import annotations
from dataclasses import replace
from uuid import uuid4
import pytest
from fastapi import HTTPException
from sqlalchemy.ext.asyncio import AsyncEngine, create_async_engine
from sqlmodel import SQLModel, col, select
from sqlmodel.ext.asyncio.session import AsyncSession
from app.api.deps import ActorContext
from app.api.tasks import _TaskUpdateInput, _apply_lead_task_update
from app.models.agents import Agent
from app.models.boards import Board
from app.models.organizations import Organization
from app.models.task_dependencies import TaskDependency
from app.models.tasks import Task
async def _make_engine() -> AsyncEngine:
engine = create_async_engine("sqlite+aiosqlite:///:memory:")
async with engine.connect() as conn, conn.begin():
await conn.run_sync(SQLModel.metadata.create_all)
return engine
async def _make_session(engine: AsyncEngine) -> AsyncSession:
return AsyncSession(engine, expire_on_commit=False)
@pytest.mark.asyncio
async def test_lead_update_rejects_assignment_change_when_task_blocked() -> None:
engine = await _make_engine()
try:
async with await _make_session(engine) as session:
org_id = uuid4()
board_id = uuid4()
lead_id = uuid4()
worker_id = uuid4()
dep_id = uuid4()
task_id = uuid4()
session.add(Organization(id=org_id, name="org"))
session.add(Board(id=board_id, organization_id=org_id, name="b", slug="b"))
session.add(
Agent(
id=lead_id,
name="Lead",
board_id=board_id,
gateway_id=uuid4(),
is_board_lead=True,
openclaw_session_id="agent:lead:session",
),
)
session.add(
Agent(
id=worker_id,
name="Worker",
board_id=board_id,
gateway_id=uuid4(),
is_board_lead=False,
openclaw_session_id="agent:worker:session",
),
)
session.add(Task(id=dep_id, board_id=board_id, title="dep", description=None))
session.add(
Task(
id=task_id,
board_id=board_id,
title="t",
description=None,
status="review",
assigned_agent_id=None,
),
)
session.add(
TaskDependency(
board_id=board_id,
task_id=task_id,
depends_on_task_id=dep_id,
),
)
await session.commit()
lead = (await session.exec(select(Agent).where(col(Agent.id) == lead_id))).first()
task = (await session.exec(select(Task).where(col(Task.id) == task_id))).first()
assert lead is not None
assert task is not None
update = _TaskUpdateInput(
task=task,
actor=ActorContext(actor_type="agent", agent=lead),
board_id=board_id,
previous_status=task.status,
previous_assigned=task.assigned_agent_id,
status_requested=False,
updates={"assigned_agent_id": worker_id},
comment=None,
depends_on_task_ids=None,
tag_ids=None,
)
with pytest.raises(HTTPException) as exc:
await _apply_lead_task_update(session, update=update)
assert exc.value.status_code == 409
detail = exc.value.detail
assert isinstance(detail, dict)
assert detail["code"] == "task_blocked_cannot_transition"
assert detail["blocked_by_task_ids"] == [str(dep_id)]
# DB unchanged
reloaded = (await session.exec(select(Task).where(col(Task.id) == task_id))).first()
assert reloaded is not None
assert reloaded.status == "review"
assert reloaded.assigned_agent_id is None
finally:
await engine.dispose()
@pytest.mark.asyncio
async def test_lead_update_rejects_status_change_when_task_blocked() -> None:
engine = await _make_engine()
try:
async with await _make_session(engine) as session:
org_id = uuid4()
board_id = uuid4()
lead_id = uuid4()
dep_id = uuid4()
task_id = uuid4()
session.add(Organization(id=org_id, name="org"))
session.add(Board(id=board_id, organization_id=org_id, name="b", slug="b"))
session.add(
Agent(
id=lead_id,
name="Lead",
board_id=board_id,
gateway_id=uuid4(),
is_board_lead=True,
openclaw_session_id="agent:lead:session",
),
)
session.add(Task(id=dep_id, board_id=board_id, title="dep", description=None))
session.add(
Task(
id=task_id,
board_id=board_id,
title="t",
description=None,
status="review",
),
)
session.add(
TaskDependency(
board_id=board_id,
task_id=task_id,
depends_on_task_id=dep_id,
),
)
await session.commit()
lead = (await session.exec(select(Agent).where(col(Agent.id) == lead_id))).first()
task = (await session.exec(select(Task).where(col(Task.id) == task_id))).first()
assert lead is not None
assert task is not None
update = _TaskUpdateInput(
task=task,
actor=ActorContext(actor_type="agent", agent=lead),
board_id=board_id,
previous_status=task.status,
previous_assigned=task.assigned_agent_id,
status_requested=True,
updates={"status": "done"},
comment=None,
depends_on_task_ids=None,
tag_ids=None,
)
with pytest.raises(HTTPException) as exc:
await _apply_lead_task_update(session, update=update)
assert exc.value.status_code == 409
detail = exc.value.detail
assert isinstance(detail, dict)
assert detail["code"] == "task_blocked_cannot_transition"
assert detail["blocked_by_task_ids"] == [str(dep_id)]
reloaded = (await session.exec(select(Task).where(col(Task.id) == task_id))).first()
assert reloaded is not None
assert reloaded.status == "review"
finally:
await engine.dispose()