From 7cfb3586ae250ca1e9525215fe6b715895413400 Mon Sep 17 00:00:00 2001
From: Abhimanyu Saharan <asaharan@onemindservices.com>
Date: Mon, 2 Feb 2026 00:08:25 +0530
Subject: [PATCH] Prevent duplicate project members; improve comments display

---
 .../api/__pycache__/projects.cpython-312.pyc  | Bin 6101 -> 6534 bytes
 backend/app/api/projects.py                   |   3 +++
 frontend/src/app/projects/[id]/page.tsx       |   7 ++++++-
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/backend/app/api/__pycache__/projects.cpython-312.pyc b/backend/app/api/__pycache__/projects.cpython-312.pyc
index 812ab690ecdd3563b3ce42e7509116d1d190b5b7..10d14eccf9585057b3546001945507df7655fb49 100644
GIT binary patch
delta 698
zcmcbr-)78rnwOW00SKJu)@Lpi*vNN`he?TP@?Li7$+FzRJS8k3IS|O=n#?F9EX|k&
zRt*t@k=Ysy46B(Y^RZ}g)H2sF7x9+xPd>*lAyC2!Q&GcE1JnsJL6tE}049o{*RZT+
zhVW`xYM8QwCkG0N@U3Qq2r)7Mg+wRM=a6R<2T4pmDa0)-3DaD|l){k0TEmhhHJMRZ
zgbipD3(zK@GNvqn$saj{g<0k>uVG)!hGv$m8cQ&PCWl|<OrR}QBEG4)NvTB&i8)27
zi7Ax|i76?mDMdy=J(KzQ%r*Fm#DL5q4iLcuA{;=36^L*K61P~>GK-2!ir6Om@hNGr
zLL}5dveF<~j?{|G;*!j~^jmDXU~7s&;i53Pmrt(V3&=7D;^JRGqJiN7zgT}wXU!b9
zCAODk46n<WUz9Q5!+YH#;G#vqg^;+57I9Y+a<3;;UQDR`z`#()=*sjRL<KT^gj0z?
z-e(2|*&q-p5DZcv5DAh8k|2?2rUs9j?EH85q*pLs;56~N!smT~!~4$W-F)^;jGmK!
z3uv+i0^Q=XSyND*iP2|rpm4lE08pR^?x7;j$p?hBSc8Fr@sr;Re`gGtyir7isVHRf
zUlDoj5Rh811~3a00!8dVLX!g$E=ck~^%9fgMQ;m$LZQeXM1ZU=3ZCpGCd-(xIYW${
ZQ9zJU=rc0|lMCYqCLr^J#^ieOFaSyDoZ<ig

delta 422
zcmZoOzN*i6nwOW00SIJf)@QEe-^h22N6dtgfnhpB36O+<8ipFiET+i;yrPqn1cmw5
zFs^2XNYpadFioDoDl)mBgMYFShxFv_f)YSB&*Yne{H#nh%vpSsKXM35G6M}@&SHWY
zhoC3N3yKM)FwS9K!?KzUBFxADG}4emW^#fE3u`cgCad3MS$=a4jv^kQe3A3y8h#~N
zmLe+<M;$~+1BqK~xv9BHsYS&sK+fc2{Bi;wK!!OG7dHWk28Jh_a|G;}7~LnY5z=J!
z2MT#^z9pp2#OO7dNi<%-4=8{ztjK+Gp{N#XAW$%7@&eKC;z1y3kTpf@KthuZVtLTy
zbz<_`U^%dUG*ui>RUmB;d7yfU$pYfH!EP(^1xbKhQWQA(x40~0+-6A$c18g{MxoEl
S3`{PJADDp54@#2_B*OrEpHq|o

diff --git a/backend/app/api/projects.py b/backend/app/api/projects.py
index 928e9720..22ecba5f 100644
--- a/backend/app/api/projects.py
+++ b/backend/app/api/projects.py
@@ -54,6 +54,9 @@ def list_project_members(project_id: int, session: Session = Depends(get_session
 
 @router.post("/{project_id}/members", response_model=ProjectMember)
 def add_project_member(project_id: int, payload: ProjectMember, session: Session = Depends(get_session)):
+    existing = session.exec(select(ProjectMember).where(ProjectMember.project_id == project_id, ProjectMember.employee_id == payload.employee_id)).first()
+    if existing:
+        raise HTTPException(status_code=409, detail="Member already added")
     member = ProjectMember(project_id=project_id, employee_id=payload.employee_id, role=payload.role)
     session.add(member)
     session.commit()
diff --git a/frontend/src/app/projects/[id]/page.tsx b/frontend/src/app/projects/[id]/page.tsx
index 30acfe99..6845cfe2 100644
--- a/frontend/src/app/projects/[id]/page.tsx
+++ b/frontend/src/app/projects/[id]/page.tsx
@@ -166,6 +166,9 @@ export default function ProjectDetailPage() {
                 <option key={e.id ?? e.name} value={e.id ?? ""}>{e.name}</option>
               ))}
             </Select>
+            {addMember.error ? (
+              <div className="text-xs text-destructive">{(addMember.error as Error).message}</div>
+            ) : null}
             <ul className="space-y-2">
               {projectMembers.map((m) => (
                 <li key={m.id ?? `${m.project_id}-${m.employee_id}`} className="rounded-md border p-2 text-sm">
@@ -273,7 +276,9 @@ export default function ProjectDetailPage() {
             <ul className="space-y-2">
               {(comments.data ?? []).map((c) => (
                 <li key={String(c.id)} className="rounded-md border p-2 text-sm">
-                  {c.body}
+                  <div className="font-medium">{employeeName(c.author_employee_id)}</div>
+                  <div className="text-xs text-muted-foreground">{new Date(c.created_at).toLocaleString()}</div>
+                  <div className="mt-1">{c.body}</div>
                 </li>
               ))}
               {(comments.data ?? []).length === 0 ? (