yunxiafei/openclaw-mission-control
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: reset sidebar state on navigation to prevent ghost re-open

Browse Source 
Use React's canonical "store info from previous renders" pattern:
conditional setState during render resets sidebar when pathname
changes, preventing the sidebar from re-opening on back-navigation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
0xjjjjjj
2026-03-07 21:28:55 -08:00
parent 2519af2395
commit 74792593b2
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
frontend/src/components/templates/DashboardShell.tsx
View File

@@ -23,9 +23,13 @@ export function DashboardShell({ children }: { children: ReactNode }) {
const { isSignedIn } = useAuth();
const isOnboardingPath = pathname === "/onboarding";
const [sidebarState, setSidebarState] = useState({ open: false, path: pathname });
// Sidebar auto-closes on navigation: when pathname changes, the derived
// value becomes false without any setState or ref access during render.
const sidebarOpen = sidebarState.path === pathname && sidebarState.open;
// Close sidebar on navigation using React's "store info from previous
// renders" pattern — conditional setState during render resets immediately
// without extra commits, avoiding both set-state-in-effect and refs rules.
if (sidebarState.path !== pathname) {
setSidebarState({ open: false, path: pathname });
}
const sidebarOpen = sidebarState.open;
const meQuery = useGetMeApiV1UsersMeGet<
getMeApiV1UsersMeGetResponse,