feat(boards): add 'comment_required_for_review' rule and update related logic

backend/tests/test_board_schema.py

@@ -86,6 +86,7 @@ def test_board_rule_toggles_have_expected_defaults() -> None:
     )
     assert created.require_approval_for_done is True
     assert created.require_review_before_done is False
+    assert created.comment_required_for_review is False
     assert created.block_status_changes_with_pending_approval is False
     assert created.only_lead_can_change_status is False
     assert created.max_agents == 1
@@ -93,12 +94,14 @@ def test_board_rule_toggles_have_expected_defaults() -> None:
     updated = BoardUpdate(
         require_approval_for_done=False,
         require_review_before_done=True,
+        comment_required_for_review=True,
         block_status_changes_with_pending_approval=True,
         only_lead_can_change_status=True,
         max_agents=3,
     )
     assert updated.require_approval_for_done is False
     assert updated.require_review_before_done is True
+    assert updated.comment_required_for_review is True
     assert updated.block_status_changes_with_pending_approval is True
     assert updated.only_lead_can_change_status is True
     assert updated.max_agents == 3

backend/tests/test_task_agent_permissions.py

@@ -756,7 +756,89 @@ async def test_non_lead_agent_comment_in_review_without_status_does_not_reassign
 
 
 @pytest.mark.asyncio
-async def test_non_lead_agent_moves_to_review_without_comment_or_recent_comment_fails() -> None:
+async def test_non_lead_agent_moves_to_review_without_comment_when_rule_disabled() -> None:
+    engine = await _make_engine()
+    try:
+        async with await _make_session(engine) as session:
+            org_id = uuid4()
+            board_id = uuid4()
+            gateway_id = uuid4()
+            worker_id = uuid4()
+            lead_id = uuid4()
+            task_id = uuid4()
+
+            session.add(Organization(id=org_id, name="org"))
+            session.add(
+                Gateway(
+                    id=gateway_id,
+                    organization_id=org_id,
+                    name="gateway",
+                    url="https://gateway.local",
+                    workspace_root="/tmp/workspace",
+                ),
+            )
+            session.add(
+                Board(
+                    id=board_id,
+                    organization_id=org_id,
+                    name="board",
+                    slug="board",
+                    gateway_id=gateway_id,
+                    comment_required_for_review=False,
+                ),
+            )
+            session.add(
+                Agent(
+                    id=worker_id,
+                    name="worker",
+                    board_id=board_id,
+                    gateway_id=gateway_id,
+                    status="online",
+                ),
+            )
+            session.add(
+                Agent(
+                    id=lead_id,
+                    name="Lead Agent",
+                    board_id=board_id,
+                    gateway_id=gateway_id,
+                    status="online",
+                    is_board_lead=True,
+                ),
+            )
+            session.add(
+                Task(
+                    id=task_id,
+                    board_id=board_id,
+                    title="assigned task",
+                    description="",
+                    status="in_progress",
+                    assigned_agent_id=worker_id,
+                    in_progress_at=utcnow(),
+                ),
+            )
+            await session.commit()
+
+            task = (await session.exec(select(Task).where(col(Task.id) == task_id))).first()
+            assert task is not None
+            actor = (await session.exec(select(Agent).where(col(Agent.id) == worker_id))).first()
+            assert actor is not None
+
+            updated = await tasks_api.update_task(
+                payload=TaskUpdate(status="review"),
+                task=task,
+                session=session,
+                actor=ActorContext(actor_type="agent", agent=actor),
+            )
+
+            assert updated.status == "review"
+            assert updated.assigned_agent_id == lead_id
+    finally:
+        await engine.dispose()
+
+
+@pytest.mark.asyncio
+async def test_non_lead_agent_moves_to_review_without_comment_or_recent_comment_fails_when_rule_enabled() -> None:
     engine = await _make_engine()
     try:
         async with await _make_session(engine) as session:
@@ -783,6 +865,7 @@ async def test_non_lead_agent_moves_to_review_without_comment_or_recent_comment_
                     name="board",
                     slug="board",
                     gateway_id=gateway_id,
+                    comment_required_for_review=True,
                 ),
             )
             session.add(